1 | |
|
2 | |
|
3 | |
|
4 | |
|
5 | |
|
6 | |
|
7 | |
|
8 | |
|
9 | |
|
10 | |
|
11 | |
|
12 | |
|
13 | |
|
14 | |
|
15 | |
|
16 | |
|
17 | |
|
18 | |
|
19 | |
package com.puppycrawl.tools.checkstyle.checks.coding; |
20 | |
|
21 | |
import com.puppycrawl.tools.checkstyle.api.Check; |
22 | |
import com.puppycrawl.tools.checkstyle.api.DetailAST; |
23 | |
import com.puppycrawl.tools.checkstyle.api.ScopeUtils; |
24 | |
import com.puppycrawl.tools.checkstyle.api.TokenTypes; |
25 | |
|
26 | |
import com.puppycrawl.tools.checkstyle.checks.CheckUtils; |
27 | |
|
28 | |
|
29 | |
|
30 | |
|
31 | |
|
32 | |
|
33 | |
|
34 | |
|
35 | |
|
36 | |
|
37 | |
|
38 | |
|
39 | |
|
40 | |
|
41 | |
|
42 | |
|
43 | |
|
44 | |
|
45 | |
|
46 | |
|
47 | |
|
48 | |
|
49 | |
|
50 | |
|
51 | 1 | public class ExplicitInitializationCheck extends Check |
52 | |
{ |
53 | |
@Override |
54 | |
public final int[] getDefaultTokens() |
55 | |
{ |
56 | 1 | return new int[] {TokenTypes.VARIABLE_DEF}; |
57 | |
} |
58 | |
|
59 | |
@Override |
60 | |
public final int[] getRequiredTokens() |
61 | |
{ |
62 | 0 | return getDefaultTokens(); |
63 | |
} |
64 | |
|
65 | |
@Override |
66 | |
public void visitToken(DetailAST aAST) |
67 | |
{ |
68 | |
|
69 | |
|
70 | 40 | if (ScopeUtils.isLocalVariableDef(aAST) |
71 | |
|| ScopeUtils.inInterfaceOrAnnotationBlock(aAST)) |
72 | |
{ |
73 | 9 | return; |
74 | |
} |
75 | |
|
76 | 31 | final DetailAST assign = aAST.findFirstToken(TokenTypes.ASSIGN); |
77 | 31 | if (assign == null) { |
78 | |
|
79 | 4 | return; |
80 | |
} |
81 | |
|
82 | 27 | final DetailAST modifiers = aAST.findFirstToken(TokenTypes.MODIFIERS); |
83 | 27 | if ((modifiers != null) |
84 | |
&& modifiers.branchContains(TokenTypes.FINAL)) |
85 | |
{ |
86 | |
|
87 | 0 | return; |
88 | |
} |
89 | |
|
90 | 27 | final DetailAST type = aAST.findFirstToken(TokenTypes.TYPE); |
91 | 27 | final DetailAST ident = aAST.findFirstToken(TokenTypes.IDENT); |
92 | 27 | final DetailAST exprStart = |
93 | |
assign.getFirstChild().getFirstChild(); |
94 | 27 | if (isObjectType(type) |
95 | |
&& (exprStart.getType() == TokenTypes.LITERAL_NULL)) |
96 | |
{ |
97 | 10 | log(ident, "explicit.init", ident.getText(), "null"); |
98 | |
} |
99 | |
|
100 | 27 | final int primitiveType = type.getFirstChild().getType(); |
101 | 27 | if ((primitiveType == TokenTypes.LITERAL_BOOLEAN) |
102 | |
&& (exprStart.getType() == TokenTypes.LITERAL_FALSE)) |
103 | |
{ |
104 | 1 | log(ident, "explicit.init", ident.getText(), "false"); |
105 | |
} |
106 | 27 | if (isNumericType(primitiveType) && isZero(exprStart)) { |
107 | 6 | log(ident, "explicit.init", ident.getText(), "0"); |
108 | |
} |
109 | 27 | if ((primitiveType == TokenTypes.LITERAL_CHAR) |
110 | |
&& (isZero(exprStart) |
111 | |
|| ((exprStart.getType() == TokenTypes.CHAR_LITERAL) |
112 | |
&& "'\\0'".equals(exprStart.getText())))) |
113 | |
{ |
114 | 2 | log(ident, "explicit.init", ident.getText(), "\\0"); |
115 | |
} |
116 | 27 | } |
117 | |
|
118 | |
|
119 | |
|
120 | |
|
121 | |
|
122 | |
|
123 | |
private boolean isObjectType(DetailAST aType) |
124 | |
{ |
125 | 27 | final int type = aType.getFirstChild().getType(); |
126 | 27 | return ((type == TokenTypes.IDENT) || (type == TokenTypes.DOT) |
127 | |
|| (type == TokenTypes.ARRAY_DECLARATOR)); |
128 | |
} |
129 | |
|
130 | |
|
131 | |
|
132 | |
|
133 | |
|
134 | |
|
135 | |
|
136 | |
private boolean isNumericType(int aType) |
137 | |
{ |
138 | 27 | return ((aType == TokenTypes.LITERAL_BYTE) |
139 | |
|| (aType == TokenTypes.LITERAL_SHORT) |
140 | |
|| (aType == TokenTypes.LITERAL_INT) |
141 | |
|| (aType == TokenTypes.LITERAL_FLOAT) |
142 | |
|| (aType == TokenTypes.LITERAL_LONG) |
143 | |
|| (aType == TokenTypes.LITERAL_DOUBLE)); |
144 | |
} |
145 | |
|
146 | |
|
147 | |
|
148 | |
|
149 | |
|
150 | |
private boolean isZero(DetailAST aExpr) |
151 | |
{ |
152 | 13 | final int type = aExpr.getType(); |
153 | 13 | switch (type) { |
154 | |
case TokenTypes.NUM_FLOAT: |
155 | |
case TokenTypes.NUM_DOUBLE: |
156 | |
case TokenTypes.NUM_INT: |
157 | |
case TokenTypes.NUM_LONG: |
158 | 10 | final String text = aExpr.getText(); |
159 | 10 | return (0 == CheckUtils.parseFloat(text, type)); |
160 | |
default: |
161 | 3 | return false; |
162 | |
} |
163 | |
} |
164 | |
} |