The following document contains the results of FindBugs Report
FindBugs Version is 2.0.2
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new com.puppycrawl.tools.checkstyle.DefaultLogger(OutputStream, boolean, OutputStream, boolean): new java.io.PrintWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 82 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.puppycrawl.tools.checkstyle.Main.loadProperties(File) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 280 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The field com.puppycrawl.tools.checkstyle.api.AuditEvent.mMessage is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.puppycrawl.tools.checkstyle.api.LineColumn defines compareTo(LineColumn) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 61 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in com.puppycrawl.tools.checkstyle.checks.DeclarationCollector.collectDeclarations(Deque, DetailAST) where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 147 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in com.puppycrawl.tools.checkstyle.checks.LineSeparatorOption.matches(byte[]): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 60 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of targetAST in com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder.visitToken(DetailAST) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 320 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.puppycrawl.tools.checkstyle.checks.UniquePropertiesCheck.processFiltered(File, List) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 68 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck.visitToken(DetailAST) where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 236 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in com.puppycrawl.tools.checkstyle.doclets.CheckDocsDoclet.start(RootDoc): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 162 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.puppycrawl.tools.checkstyle.doclets.CheckDocsDoclet$ClassDocByCheckNameComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 52 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in com.puppycrawl.tools.checkstyle.doclets.TokenTypesDoclet.start(RootDoc): new java.io.PrintStream(OutputStream) | I18N | DM_DEFAULT_ENCODING | 59 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of com.puppycrawl.tools.checkstyle.filters.SuppressWithNearbyCommentFilter.DEFAULT_MESSAGE_FORMAT which is known to be null in new com.puppycrawl.tools.checkstyle.filters.SuppressWithNearbyCommentFilter() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 317 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.puppycrawl.tools.checkstyle.filters.SuppressWithNearbyCommentFilter$Tag defines compareTo(SuppressWithNearbyCommentFilter$Tag) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 184 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
com.puppycrawl.tools.checkstyle.filters.SuppressionCommentFilter$Tag defines compareTo(SuppressionCommentFilter$Tag) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 188 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new com.puppycrawl.tools.checkstyle.grammars.GeneratedJavaLexer(LexerSharedInputState) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to currentAST in com.puppycrawl.tools.checkstyle.grammars.GeneratedJavaRecognizer.typeArgumentsOrParametersEnd() | STYLE | DLS_DEAD_LOCAL_STORE | 1405 | High |
com.puppycrawl.tools.checkstyle.grammars.GeneratedJavaRecognizer._tokenNames should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 7599 | Medium |
Nullcheck of annotationField_AST at line 3010 of value previously dereferenced in com.puppycrawl.tools.checkstyle.grammars.GeneratedJavaRecognizer.annotationField() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 3010 | Medium |
Nullcheck of enumConstantField_AST at line 3739 of value previously dereferenced in com.puppycrawl.tools.checkstyle.grammars.GeneratedJavaRecognizer.enumConstantField() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 3739 | Medium |
Nullcheck of field_AST at line 3350 of value previously dereferenced in com.puppycrawl.tools.checkstyle.grammars.GeneratedJavaRecognizer.field() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 3350 | Medium |